ARM: pl35x-nand-controller: Fix subpage read performance#221
Merged
gratian merged 1 commit intoni:nilrt/master/6.6from Apr 8, 2025
Merged
ARM: pl35x-nand-controller: Fix subpage read performance#221gratian merged 1 commit intoni:nilrt/master/6.6from
gratian merged 1 commit intoni:nilrt/master/6.6from
Conversation
Previous subpage read implementation found to incur performance penalty. This commit rectifies the issue by calling nand_read_page_op along with read length, data offset arguments, instead of doing a raw page read via nand_monolithic_read_page_raw. Signed-off-by: HatsyRei <yan.huan.chng@emerson.com>
chaitu236
approved these changes
Apr 8, 2025
gratian
approved these changes
Apr 8, 2025
|
Cherry-picked in nilrt/master/6.12 as b9fd08c |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When timing sha256sum operations on Bluefin devices running Linux 6.6, a discrepancy in system CPU time was found:
Linux 4.1:
Linux 6.6
The issue was traced back to nand subpage read implementation, where a full raw page read was performed instead of a subpage read. This is resolved by replacing the
nand_monolithic_read_page_rawwith anand_read_page_opcall and passing the corresponding read length and data offset. Change tested on cDAQ-9189: